Replace ModelEditorViewTracker with modeling store and events#3065
Merged
Replace ModelEditorViewTracker with modeling store and events#3065
Conversation
charisk
force-pushed
the
charisk/replace-model-editor-view-tracket
branch
from
a301004 to
8ed4be0
Compare
charisk
force-pushed
the
charisk/replace-model-editor-view-tracket
branch
from
8ed4be0 to
c93f451
Compare
norascheuch
reviewed
Nov 13, 2023
Contributor
norascheuch
left a comment
norascheuch
left a comment
There was a problem hiding this comment.
I think this looks good, I just have two questions.
Contributor
|
Have you tested the changes manually @charisk? |
Contributor
Author
Yep. Have you found any issues? |
norascheuch
approved these changes
Nov 13, 2023
Contributor
norascheuch
left a comment
norascheuch
left a comment
There was a problem hiding this comment.
Looks good, thanks! 🚀
Contributor
Author
|
It doesn't look like there's feedback from anyone else on this so I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the ModelEditorViewTracker by using the modeling store and two new events:
I prefer this solution because it means managing less state, but if people disagree, I'm happy to close the PR.
Checklist
N/A:
ready-for-doc-reviewlabel there.